Removed current_time attribute from Raincloudy sensors to avoid unnecessary updates by recorder#14584
Merged
syssi merged 1 commit intohome-assistant:devfrom May 22, 2018
Conversation
… triggered by recorder component
syssi
approved these changes
May 22, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
… triggered by recorder component (home-assistant#14584)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Removed attribute current_time from Raincloudy sensors to avoid being triggered by recorder component.
One of the Raincloudy attributes was the
current_timeon the controller to be displayed at HA. This was causing therecordercomponent to update its status whenever theattributeschanged and not only the when it thestatuschanged.Many thanks to @clboles for reporting this issue. 👍
This PR fixes this and you can find more discussion about it at vanstinator/raincloudy#23
Related issue (if applicable):
See also: vanstinator/raincloudy#23
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: